Hau-Hau / firefox-tab-suspender

A Firefox extension that automatic suspend tabs and saves memory
Other
15 stars 2 forks source link

Suspender ignores the "suspend tab after (seconds)" #42

Closed ITgreybeard closed 4 years ago

ITgreybeard commented 4 years ago

I have saved the value '900' to "suspend tab after (seconds)" but the tab is suspended after 60 seconds. So it appears that the value is disregarded.

Hau-Hau commented 4 years ago

Hello @ITgreybeard,

Today I released new version (3.5.2). Please check whether you still have problems in new version.

Best regards, Michalewicz Piotr

khawajamechatronics commented 4 years ago

Hi I am using version 3.5.2 and having same issue, its suspending tabs very quickly. Even If I switch tab for 5 secs came back to last tab and I see its suspended.

SNMetamorph commented 4 years ago

+, having same issue on last version

Hau-Hau commented 4 years ago

Thanks guys for report.

I have some questions:

1) Do you guys have this issue always or just sometimes?

2) Do you guys have this problem immediately after browser start or after some time of browsing?

3) When do you have this issue do you use only one Firefox window or multiple?

My suspicion is that problem is async of user input. Event loop runs discarding event on tabs that aren't updated. Without your answers to these questions I will not be sure where is problem. Anyway I'm starting debugging now.

Best regards, Michalewicz Piotr

khawajamechatronics commented 4 years ago

1- After first issue, it repeatedly occurs 2- After Sometime of browsing, may be after first suspend hit 3- I have multiple windows open.

hyunlee1o commented 4 years ago

I got still this problem when i switch tab from twitch.tv (When it has sound.)

Hau-Hau commented 4 years ago

@khawajamechatronics, Thanks!

@0trenixjetix, Thanks for report. I found possible gap - it is possible to suspend tab which is playing audio when e.g. video on youtube is changing. I will fix that. Issue related to problems with audio you can track here: #35

Best regards, Michalewicz Piotr

whalemonster commented 4 years ago

I also have this issue on the latest version. I have set the delay to 300s but the add-on ignores this and suspends tabs more quickly. This happens on all tabs, regardless of content.

notacompletemoron commented 4 years ago

I am having this issue, along with another which I will open a new ticket for.

Hau-Hau commented 4 years ago

Hello,

I rewrited a lot parts of C code (including event loop), this bug should't be a problem anymore. Do you guys still have this problems in newest version (3.6.0+)?

Best regards, Michalewicz Piotr

khawajamechatronics commented 4 years ago

I am using 3.7.4 and I think its much better now.