Haufe-Lexware / gocd-plugins

A collection of our OSS plugins for use with Go.CD
Apache License 2.0
36 stars 34 forks source link

Docker: Support for hub.docker.com when building and pushing #5

Closed DonMartin76 closed 8 years ago

DonMartin76 commented 8 years ago

The docker plugin worked great when either building local images or images which are intended to be pushed to a user-specified registry (like registry.haufe.io). If you wanted to push to the official docker registry though, this did not work, as it expects you to build images without specifying a registry, and logging in to https://index.docker.io/v1/ instead of e.g. docker.io or (which would make sense) hub.docker.com. The plugin now detects docker.io and hub.docker.com and "does the right thing", i.e.