search

Haufe-Lexware / wicked.haufe.io

An API Management system based on Mashape Kong
http://wicked.haufe.io
Other
124 stars 37 forks source link

apim-certs.yaml prevents successful `helm upgrade` #152

Closed stackedsax closed 5 years ago

stackedsax commented 5 years ago

Looks like apim-certs.yaml falls prey to the same issue as reported here:

If I understand it correctly, a comment followed by a variable will ignore the variable and the following line, too. This isn't apim-certs.yaml's fault, but it prevents helm upgrade from running. An upgrade will return this error:

Error: UPGRADE FAILED: failed to create patch: failed to get versionedObject: Object 'apiVersion' is missing in 'unstructured object has no version'

SImply moving the apim-certs.yaml out of the templates directory will solve the issue, but if you actually want to run that template, you're out of luck at the moment.

I'll see if I can find a fix for it.

DonMartin76 commented 5 years ago

This should be fixed in the wicked_1_0 branch of the Helm template; which branch did you use, or did you use the packaged one?

If so, it's weird, as it should be in there. Will investigate, thanks for reporting!

DonMartin76 commented 5 years ago

For the sake of completeness, here's the fix (from September):

https://github.com/Haufe-Lexware/wicked.haufe.io/commit/6b56dc6e7fd93f37029d4b70715b0fd8d1d70a56#diff-1c13465e24d91aca4d3ddaa1bc3e7027

stackedsax commented 5 years ago

I was using the 0.12.1 branch. I'll make the changes locally while I use this branch. I'll return to the 1.0 branch in a little bit. Thanks for the fix!

DonMartin76 commented 5 years ago

The 0.12.1 branch does not contain the portal-auth component, so beware of that, if you're trying to use the old helm chart with the new beta.

stackedsax commented 5 years ago

No, I was just trying a vanilla 0.12.1 helm install, just to play around. I'll return to the 1.0 beta helm install once I get 0.12.1 running happily. It looked like the 1.0 beta was going to need some work on the helm install, so I figured I'd make sure I could get the 0.12.1 version running before I moved ahead. Just trying one thing at a time.

ᐧ

On Sat, Jan 5, 2019 at 11:37 AM Martin Danielsson notifications@github.com wrote:

The 0.12.1 branch does not contain the portal-auth component, so beware of that, if you're trying to use the old helm chart with the new beta.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Haufe-Lexware/wicked.haufe.io/issues/152#issuecomment-451684614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfD8CitSi5d786-erd7y4ws5Y6AIAe6ks5vAP77gaJpZM4Zovo6 .