search

Haufe-Lexware / wicked.haufe.io

An API Management system based on Mashape Kong
http://wicked.haufe.io
Other
121 stars 37 forks source link

Typescript compile failing due to @types/node update #285

Closed shreyas-segu closed 3 years ago

shreyas-segu commented 3 years ago

Typescript compile step failing in these following modules Auth- https://github.com/Haufe-Lexware/wicked.haufe.io/blob/1efadeabae7b7ccb4b17473e9aa5d0af60796adb/src/auth/package.json#L39 Kong Adapter- https://github.com/Haufe-Lexware/wicked.haufe.io/blob/1efadeabae7b7ccb4b17473e9aa5d0af60796adb/src/kong-adapter/package.json#L27 node-sdk- https://github.com/Haufe-Lexware/wicked.haufe.io/blob/1efadeabae7b7ccb4b17473e9aa5d0af60796adb/src/node-sdk/package.json#L28

Reference to the error image

Recently @types/node updated to https://www.npmjs.com/package/@types/node/v/10.17.29

Recommended to use absolute versions as typescript keeps releasing new features and might introduce new breaking changes to the syntax. Please let me know if you agree and I can create a PR.

DonMartin76 commented 3 years ago

Sure, totally agree. I typically also like it most to use pinned versions.