HaugrNet / eds

Cryptographic Web Share
https://haugr.net/
Apache License 2.0
6 stars 0 forks source link

Enhance return messages #60

Closed knjensen closed 5 years ago

knjensen commented 5 years ago

Currently, the principal return message, when a request was successfully completed, is just "Ok". This is not the most informative information. For integration into other systems it may be enough, but for usage directly in a frontend system, a more information message may help.

Goal is to enhance the return messages with the information already present, meaning without having to read more information from the database. The enhanced messages should try in a single sentence to explain what took place, i.e. "Added member 'X' to the Circle of Trust 'Y'-"

knjensen commented 5 years ago

It seems that there is no message if the DB is not ready - should be tested and better documented.

knjensen commented 5 years ago

It seems that there is no message if the DB is not ready - should be tested and better documented.

The check method is actually logging this. This should be sufficient. If a problem, then it should be resolved in a new ticket, and not as part of the return message issue.

knjensen commented 5 years ago

The Return Messages for processing requests have been updated. Closing ticket now.

knjensen commented 5 years ago

Note, fix was made in the 1.1 branch, as it may be relevant for others depending on the logic in 1.1 but won't wait for the later versions.