search

HausDAO / daohaus-app

long live pokemol
https://daohaus.club/
Other
134 stars 79 forks source link

WalletConnect: Provide a network select UI and set chainId #1618

Open PeterTheOne opened 2 years ago

PeterTheOne commented 2 years ago

Description With WalletConnect the Dapp tells the wallet which network to connect to on establishing the connection. Currently daohaus just always requests chainId 1 which is Ethereum, if you want to connect to xDai Chain/Gnosis Chain it still connects to Ethereum. Multichain wallets like Minerva Wallet depend on this initial chainId to select the correct network. Having a single network as the active network and switch it from the Wallet side is a logic that was established by MetaMask that isn't followed by every Wallet.

How to Reproduce Steps to reproduce the behavior:

  1. Go to Connect Wallet and select WalletConnect.
  2. Scan the QR code with Minerva Wallet or AlphaWallet.
  3. It connects to Ethereum but you wanted to connect to xDai Chain/Gnosis Chain.

Expected behavior After selecting WalletConnect there should be a selection for which Network to connect to. There are examples for this: Honeyswap DEX, Superfluid, 1inch.

Jds-23 commented 2 years ago

Hey @PeterTheOne would like to work on this.

ghost commented 2 years ago

@Jds-23 I can work on this, is that alright?

Edit: typo

Jds-23 commented 2 years ago

@Azephiar sure go ahead

PeterTheOne commented 2 years ago

@Jds-23 @Azephiar Any progress?