plor commented 2 years ago

final fix - https://github.com/HausDAO/daohaus-app/pull/1948

Describe the bug Minion transfer - early execution Problem: The early execution was a success but voting is still enabled. https://app.daohaus.club/dao/0x64/0xcd8fad1a2fc74bce90e9f5fd87164c68ecca9c12/proposals/280

To Reproduce Steps to reproduce the behavior:

Submit minion proposal with early execution
Vote yes and execute
Switch to another wallet that has membership
See that you are still able to vote after executing

Expected behavior

After execution UI should no longer show the vote buttons.

Actual behavior

Voting is still shown after execution has been done.

Screenshots

Application area

Where in the app is this happening?

FrontEnd (please include route/section if possible)

Additional context To reproduce you'll need to have access to two wallets on the same DAO. The first one to vote and execute, the second to see that voting is still showing.

plor commented 2 years ago

This works for me, though I'm having an issue with new safe minions (unrelated I think).

I did notice that the currently passing looks a bit odd with the voting buttons missing.

plor commented 2 years ago

Also, voting is still showing on the proposal list view, there are quite a few issues where the details view doesn't match the list view. Should this be created as a separate issue?