HausDAO / daohaus-app

long live pokemol
https://daohaus.club/
Other
134 stars 79 forks source link

messy eslint errors across v2 #1943

Closed brossetti1 closed 2 years ago

brossetti1 commented 2 years ago

Describe the bug our eslint settings are out of whack and working in the project is spitting out lots of incorrect and unwanted errors.

currently commenting out lines 42 - 44 in .eslintrc.js removes any of the errors/warnings we're seeing. These 3 rules:

no-unused-vars: 'off' - actually need to explicitly set this to 'off'
react/jsx-uses-react
react/jsx-uses-vars

for more reference - https://discord.com/channels/709210493549674598/951186621397618708/991744816515915876

this gets ride of the slew of errors but also turns off some crucial eslint warnings.

Expected behavior

We should turn them back on one at a time and correct the behavior across the app in this story

Actual behavior

lots of errors across the app due to breaking eslint rules or incorrect usage of eslint

Screenshots

image

jordanlesich commented 2 years ago

More behavior notes:

Other possibility: