Fix formatting early execute

brossetti1 commented 2 years ago

GitHub Issue

https://github.com/HausDAO/daohaus-app/issues/1917

Changes

there are a few fixes on here:

[X] change Icon (with onClick) to IconButton as recommended by Chalkra UI
[X] changing to an IconButton allow the use of disable in the case that a proposal has been early executed while voting is active.
[X] adjust the text displayed when the the proposal can be early exeucted vs just executed in a normal fashion
[X] adds the config for the SAFE_MINION_V2 ABI fetching. This config fixes alot of issues with the proposal card and we should probably emphasis testing this config for any side effects

still some light updates and testing to do on my end.

Checks

Before making your PR, please check the following:

[X] Critical lint errors are resolved
[X] App runs and builds locally

brossetti1 commented 2 years ago

fixes 1917

@plor this is ready to test

brossetti1 commented 2 years ago

@jordanlesich wondering if the addition of the MINION_SAFE_V2_EXECUTE config could resolve the issues you were mentioning with some safe errors around the app?

the proposal card was acting weird until I added this config which fixed an error in calling the v2 (i think its actually v3 safes as labeled in the app) - here is the relavent config additions

https://github.com/HausDAO/daohaus-app/pull/1948/files#diff-9633ef496c2b9b472acbb53b245b1113df0816a122314966963451780a63520bR639-R641

what I am wondering though, could there be side effects somewhere around the app that I am missing here with adding this abi config, from your perspective?

anyways, added you in case you have some thoughts here

brossetti1 commented 2 years ago

merged with eslint fixes and pulling back to draft until we test this through qa

brossetti1 commented 2 years ago

fixes https://github.com/HausDAO/daohaus-app/issues/1917

HausDAO / daohaus-app