Remove Lit feature flag

HausDAO / daohaus-app

long live pokemol

https://daohaus.club/

Other

134 stars 79 forks source link

Remove Lit feature flag #1960

Open plor opened 2 years ago

plor commented 2 years ago

https://github.com/HausDAO/daohaus-app/issues/1774 was developed for Lit integration, but they didn't have some API to support it. We merged the code but put it in a feature flag that can be removed once everything is good and working.

relavent pr and comment - https://github.com/HausDAO/daohaus-app/pull/1897#issuecomment-1171471290

brossetti1 commented 2 years ago

spoke with Chris at Lit

follow up tasks for our side:

[ ] add chain to url variables - for v3 modal.
[ ] generate auth sig on our side and pass as url param
[ ] pass null in signature on daohaus side, along with switchChains: false.
[ ] redirect to lit protocol will add the signature into the url button will do this while also the signature we collect on our side.

plor commented 2 years ago

Should I separate these into separate issues so we can work piecemeal on it, or are these all just necessary for removing the flag?

brossetti1 commented 2 years ago

these are all required for removing the flag - lets leave them here. Chris from Lit has to make changes on his end, which prompted these changes here -- there are some small issues with the signature collection on their end, but we worked out a way to make the flow much easier for our users and their users.

We just have to wait on his updates now, i addressed a most of these after our call already

plor commented 2 years ago

I moved to "ready for dev" so you can start working on the follow up tasks at your leisure, no rush though.

plor commented 2 years ago

Lit responded Friday, going to finish this up.

brossetti1 commented 2 years ago

looked at finishing this up after recieving some communication back from chris at lit, seems like there are still some issues to be worked out here on lits side - sent a message back to chris on the matter

plor commented 2 years ago

can the follow-up tasks be tackled or are we fully blocked?

brossetti1 commented 2 years ago

blocked until chris gets back, some things we discussed the other week still have not been addressed, they ar emaking progress, but its still a blocker for us

plor commented 2 years ago

@brossetti1 any more word from Lit? I'd be happy to try to close this out so you can focus on V3 if that is possible.