HausDAO / daohaus-app

long live pokemol
https://daohaus.club/
Other
134 stars 79 forks source link

Bug: funding minion through proposal regression #1986

Closed plor closed 2 years ago

plor commented 2 years ago

Describe the bug Sending funds to a minion through a standard proposal and then using the deposit in minion vault function is no longer working.

I think this is because it is using the crossWithdraw function instead of the standard withdraw function in the minion.

thinking this is from an audit fix in the new version

example rinkeby dao https://app.daohaus.club/dao/0x4/0x5bde139fadc0c2c9ef62067f9e7db4b507ea4ce0/vaults/minion/0x593f6e600ee2858d447a2e933cb3d251fa7cf437

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Proposal to send funds to minion should result in funds

Actual behavior

A clear and concise description of what is actually happening.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional Questions

  1. [ ] Is there a security breach?
  2. [ ] Is there an issue with the smart contracts?
  3. [ ] Is there a loss of funds, shares or loot?

Application area

Where in the app is this happening?

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.