HausDAO / daohaus-monorepo-deprecated

MIT License
13 stars 5 forks source link

Feature/932 ghost button #1030

Closed 0xRowdy closed 1 year ago

0xRowdy commented 1 year ago

GitHub Issue

Add a link to the GitHub issue.

Changes

A summary of the changes in the code in this PR. If making any UI changes consider adding screenshots or gifs.

Packages Added

Brief list of any packages added, and if folks need to rerun yarn install to run locally

Checks

Before making your PR, please check the following:

0xRowdy commented 1 year ago

I don't want to bloat out this PR anymore but a few items have emerged out of reviewing the code used in out apps. I've created the following tickets to address some of the following issues.

Create a Profile specific variant of the button that also has the Avatar Profile Component in it. Create a Dropdown Checkbox component so that we don't hack a dropdown Button (Filters dropdown in Core) Enhance Button Component or add a Loading button Component for Icon buttons and Loading Buttons. This will allow for a button to accept a loading prop and show the spinner. We will hide the text of the button and show the loader over top to prevent buttons from resizing.

#1033 #1032 #989

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6935537
Status:🚫  Build failed.

View logs