HausDAO / daohaus-monorepo-deprecated

MIT License

13 stars 5 forks source link

remove `react-router` from @daohaus/ui #971

Closed brossetti1 closed 1 year ago

brossetti1 commented 2 years ago

Problem

react-router-dom is included in the @daohaus/ui library in one place: https://github.com/HausDAO/daohaus-monorepo/blob/ef95ebedaa0e23623a430fc4bc3279b854941a4d/libs/ui/src/components/atoms/Link/Link.styles.ts#L0-L1

removing dependencies like this will shrink our packages and make them easier to run externally

Solution

remove Link and manipulate UI link instead -- react-router-link can be manipulated in app level logic

0xRowdy commented 1 year ago

Currently tracking in #150. Closing this issue to remove duplication.