search

HausDAO / daohaus-supergraph

MIT License
6 stars 22 forks source link

Why isn't DaoMetadata linked to the moloch id? #47

Open dysbulic opened 3 years ago

dysbulic commented 3 years ago

I saw this comment which says that the title for a DAO is now stored in the metadata. I also see that in The Graph explorer there's a DaoMeta type that can return that title.

I can copy the id returned from:

{ moloches { id } }

into a query like:

{
  daoMetas(where: {id:"0x014ded81ddb85f7d178a66bcdd6cd6ca89ba7cc5"}) {
    title
  }
}

and get the title. I don't understand why I can't do:

{
  moloches {
    daoMeta { title }
  }
}

Could you clarify as to why that field isn't linked in that way?

skuhlmann commented 3 years ago

@dysbulic

That daometa entity and the title field is misleading. We've been meaning to remove it. Apologies for the confusion on that.

The title field is a remnant of the V1 and an early V2 factory contract. There is actually no title stored on chain in the moloch contracts. Since moving to the v2.1 moloch we no longer have that field provided when summoning, so it'll be null on many daos.

Might be good to remove queries on daometa and any reliance on the title field in your dapp.

daometa is maintained by dao members and accessible here now: https://data.daohaus.club/dao/0x014ded81ddb85f7d178a66bcdd6cd6ca89ba7cc5

more talk about it here: https://github.com/HausDAO/daohaus-supergraph/issues/44