search

HaveAGitGat / Tdarr

Tdarr - Distributed transcode automation using FFmpeg/HandBrake + Audio/Video library analytics + video health checking (Windows, macOS, Linux & Docker)
Other
3.06k stars 96 forks source link

Upgrade to FFMPEG 7 #1089

Open Re4zOon opened 1 month ago

Re4zOon commented 1 month ago

FFMPEG 7 is out since a while, jellifyn builds also available as 7.0.2-2. As its over some bugfix iterataions, could you upgrade to it? Also I think your dockerfile is already broken due to this, as you've hard-coded "ffmpeg6" to the download: https://github.com/HaveAGitGat/Tdarr/blob/master/docker/Dockerfile.base#L96

taltamir commented 1 month ago

Oddly enough, while ffmpeg6 is included in the docker. tdarr node updater downloads tdarr_node bundled with ffmpeg5.0.1 instead. which is in even more dire need of an update.

additionally the node bundled version is the static release from johnvansickle.com, which is built without av1 support for some reason. (I checked both v5.0.1 and v7.0.2 from johnvansickle.com and all were built without av1 support)

while the docker version is built by ubuntu and DOES include av1 support.

for now I suggest editing the node_config to set the target location of ffmpeg to your OS' release version. such as /usr/bin/ffmpeg