search

HaveAGitGat / Tdarr

Tdarr - Distributed transcode automation using FFmpeg/HandBrake + Audio/Video library analytics + video health checking (Windows, macOS, Linux & Docker)
Other
3.06k stars 96 forks source link

Global VARS not processed in certain situations #1095

Closed quadcom closed 1 month ago

quadcom commented 1 month ago

While this bug does reference plugins/steps. I suspect this is a processing issue and not specifically a plugin problem.

v2.26.01

I have added some global VARS (this may apply to other VAR types as well). While I can reference these in some flow steps, such as setting the -qp rate in the ffmpegCommandSetVideoEncoder step, the VAR is not referenced in other situations.

image

Here is the SetVideoEncoder image

The steps show the VAR being processed, and it is translated correctly into the FFMPEG string image image

I then have another flow step to push metadata into the 0 stream to note the same VAR image

The resulting metadata string does not have the translated VAR value. The system is doing something as it removes the VAR identification string; it's just not replacing it with the assigned value. image

supersnellehenk commented 1 month ago

I believe casing is important, and your variable is called 1080-CQ. So try changing it from 1080-cq to 1080-CQ

quadcom commented 1 month ago

Good catch! I thought I had copy/paste the var but alas, it was a different case.

Changed those, I keep an eye on it going forward and update the report.

quadcom commented 1 month ago

Yup, stung by the case bug!