search

HaveAGitGat / Tdarr_Plugins

Tdarr Plugins
GNU General Public License v3.0
140 stars 162 forks source link

feature request: plugin to check the codecs of the converted workfile #692

Open taltamir opened 2 months ago

taltamir commented 2 months ago

This is a feature request for a plug that checks for the codecs of the encoded working file. So it can be verified to have been properly converted before you replace the existing file. There is a plugin to check what codec the source file has. but not for the working file.

I have noticed the occasional odd file where audio was converted but video remained unchanged. And would like to catch those and mark them as errors

taltamir commented 2 months ago

I was able to figure out and replicate the issue. I thought it was just passing through the video, it was actually re-encoding it. coincidentally some of them re-encoded to the same format. but later on I found cases where it converted xvid to h264 and that is how i figured out the issue.

I had created a handbrake json profile for: AV1 MKV 720p Opus 160kbps and then set tdarr to use that json as the handbrake profile.

outdated versions of handbrake will incorrectly interpret the config json command for using the codec string "av1" as "avc1" which means h264 it will then perform the conversion and report success. as far as handbrake and tdarr are concerned, I correctly intentionally converted my files to h264. where my actual intent was to convert them to av1.

Some of my systems are using older versions of linux (as they require a reformat to upgrade for one reason or another so I allowed it to remain outdated). which is where the outdated handbrake comes from. Since handbrake is not included with tdarr node, instead it relies on whatever is installed on the system.

Those systems are all using the exact same version of tdarr node. and were updated the same day.

Trying to convert an AVI file with xvid video and AC3 audio to the before mentioned preset gives: linux mint 21.3 = will convert it to h264 + opus linux mint debian edition 6 = will convert it to AV1 + opus linux mint 22 = will convert it to AV1 + opus

Anyways, if there was a plugin to check the codecs of the new file instead of the source file then I would have slotted that check after the handbrake and caught it much sooner.

taltamir commented 4 weeks ago

I just had an idea. instead of a seperate plugin. take the existing checker plugin and add a choice to it on whether to check the source file or the working file