HaveIBeenPwned / EmailAddressExtractor

A project to rapidly extract all email addresses from any files in a given path
BSD 3-Clause "New" or "Revised" License
68 stars 23 forks source link

[.net7] Improvements to performance #11

Closed GStefanowich closed 1 year ago

GStefanowich commented 1 year ago

Rebased PR #8

I removed a few cases where LINQ was being used to .ToList when it was unecessary to remap. Writing lines to the file takes an Enumerable and can be passed a Set<string> without needing to convert it back to a List<string>

I also noticed that I had removed an OrderBy() that was being called while collecting the emails, and moved the sort to when it was being written to file, which may help in cases of large files.

troyhunt commented 1 year ago

That's great, nice work!