Haven-King / Atmosfera

A mod for Minecraft that adds atmospheric sounds
Apache License 2.0
26 stars 9 forks source link

1.19 update and future? #36

Open PweSol opened 2 years ago

PweSol commented 2 years ago

Hello, can we get an update to 1.19 please?

Are there any plans to continue adding music from MC Dungeons? There have been a number of updates for MCD but nothing else was added to this mod. It it just lack of interest in updating this mod or is it something like time constraints? Because I would love to see more updates to this mod.

Haven-King commented 2 years ago

1.18.1 threw a lot of wrenches into the systems Atmosfera uses and updating it would be a huge burden. I don't have the time to commit to this project anymore but would be open to somebody else with the skills to do so taking over.

Fourmisain commented 2 years ago

I was kindly informed by a stranger on CurseForge about this.

I'm not sure if I'm able to "take over" the mod and keep adding content but I can help out maintain the mod. I've been doing this for a lot of different mods, like Falling Leaves, Chat Heads, Better Enchanted Books, etc.

I actually just pretty much finished porting the mod to 1.18.2 and 1.19 and everything seems to work just fine, though it could surely do with some more testing - I put up some test releases for that reason.

Generally I find, the more members a project has, the easier it gets to keep it afloat. Alice is currently not available? No problem, Bob's still there. Wait, Bob's been away buying coffee? Let's ask Carol.

If you wanna add me to the project, I might ask Breki to help out a little too.

EGOIST1372 commented 2 years ago

@Haven-King I did ask Fourmisain to help out and he seems can help and he is a great dev with a good spirit. I hope you all can get along and continue this journey. Thanks both of you guys <3 <3

Haven-King commented 2 years ago

@Fourmisain I would be happy to have you take over as maintainer of this project! I am out of town for the next few days and unable to test your fork, but if you open a PR just so we keep the changes all together, I will try to review it this weekend and add you to both the GitHub and CurseForge projects.

EGOIST1372 commented 2 years ago

I've tested 1.19 and it works so far very well but I believe issues #20 and #28 and #29 are still present. I died while I was flying in a mountain and the sound of wind was still playing after I respawned

EGOIST1372 commented 2 years ago

@Fourmisain today I faced a fetal crash and I suspect it might be atmosfera building up memory leak and making game crash info here: https://github.com/CaffeineMC/sodium-fabric/issues/1355

Fourmisain commented 2 years ago

Those leaks are rendering related (GL_OUT_OF_MEMORY) and Atmosfera doesn't touch rendering at all (to my knowledge), so I don't think it's related.

edit: Actually, it looks like GL_OUT_OF_MEMORY doesn't have to be about VRAM at all, so scratch that idea.

Zetabite commented 2 years ago

Regarding the future of Atmosfera, i will also try to do my bit, as I like the mod too, and would like to see it more commonly used

EGOIST1372 commented 2 years ago

I guess illumination was the culprit of that crash but IDK maybe konkret update helped too

EGOIST1372 commented 2 years ago

IDK why I get so many memory leak. I even installed memory leak fix mod to combat any possible memory leak. but still there are so many logs like this: [21:35:07] [Render thread/WARN]: Reclaimed 32720 bytes at address 2233329976128 that were leaked from an unknown location (logging is disabled) I get so many sound errors like: [21:35:23] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.salmon.ambient [21:54:28] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.cod.ambient [21:50:10] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.tropical_fish.ambient [21:50:11] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.puffer_fish.ambient

these are all the sound mods that I have but none of them have anything to do with fish ambient sounds(maybe sound physics remastered) https://www.curseforge.com/minecraft/mc-mods/sound-physics-remastered https://www.curseforge.com/minecraft/mc-mods/audioplayer https://www.curseforge.com/minecraft/mc-mods/auudio-fabric https://www.curseforge.com/minecraft/mc-mods/audio-extension-for-fancymenu-fabric https://www.curseforge.com/minecraft/mc-mods/presence-footsteps https://www.curseforge.com/minecraft/mc-mods/extrasounds/ https://www.curseforge.com/minecraft/mc-mods/simple-voice-chat https://www.curseforge.com/minecraft/mc-mods/atmosfera

also getting this error : [21:55:20] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 8167ms or 163 ticks behind [21:54:57] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2242ms or 44 ticks behind

full log file: latest.log

Fourmisain commented 2 years ago

I still doubt your memory leak is caused by Atmosfera, I have done some testing on this and didn't run into any issues, though I also cannot fully dismiss it - but not for the reasons you might be thinking. Sounds not ending and stuff like that will not cause a memory leak.

Try to get rid of Farsight first and retest, that's still the most likely candidate.

About those warnings:

[21:35:07] [Render thread/WARN]: Reclaimed 32720 bytes at address 2233329976128 that were leaked from an unknown location (logging is disabled)

That's Sodium trying it's best to fix the mess.

Unable to play empty soundEvent: minecraft:entity.salmon.ambient

Those are completely normal, it's an ancient bug.

[21:55:20] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 8167ms or 163 ticks behind [21:54:57] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2242ms or 44 ticks behind

This just means the server is temporarily running slow. If your memory is nearly full and your game is chugging, this is to be expected. There are some cases where these warnings are completely normal, e.g. after booting up a dedicated server or right here in your log:

[21:48:44] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 10014ms or 200 ticks behind [21:48:44] [Render thread/INFO]: [CHAT] The nearest minecraft:desert is at [2985, 81, 3924] (4802 blocks away) [21:48:44] [Server thread/INFO]: [EGOIST23: Set own game mode to Creative Mode] [21:48:44] [Render thread/INFO]: [CHAT] Set own game mode to Creative Mode [21:48:54] [Render thread/INFO]: [CHAT] The nearest minecraft:desert is at [2985, 81, 3924] (4802 blocks away) [21:49:00] [Server thread/INFO]: [EGOIST23: Teleported EGOIST23 to 2985.500000, 81.000000, 3924.500000] [21:49:00] [Render thread/INFO]: [CHAT] Teleported EGOIST23 to 2985.500000, 81.000000, 3924.500000 [21:49:03] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 3086ms or 61 ticks behind

You used /locate, which is an expensive command (because it needs to search surroundings for your biome) and followed it up with /teleport, which loads/generates a bunch of new chunks, so it's normal for the server to run behind.

Again, please try disabling mods one-by-one and do long play sessions to get an idea if one particular mod is causing the issue or not. Logs don't help narrow down the cause, because the memory leaks are invisible.

EGOIST1372 commented 2 years ago

This just means the server is temporarily running slow. If your memory is nearly full and your game is chugging, this is to be expected

I have 32GB ram and it's not even half used when I launch minecraft and I already dedicated 6GB to it. it can't be nearly full tho but even after I teleported somewhere and let it settle and loads chunks around still has problem and is going down to even 2 fps ;-;

BTW I removed farsight and replaced phosphor with starlight and it seems fps is now 150+ even tho the chunk I'm in is not loadedd yet image

it might be phosphor or farsight. but now it's much better thanks so much <3

Fourmisain commented 2 years ago

I have 32GB ram and it's not even half used when I launch minecraft and I already dedicated 6GB to it. it can't be nearly full tho

By "memory nearly full" I mean the game's heap memory, you can see it if you press F3 on the top right. You'll see the numbers quickly rise and fall down again. When it's constantly at high values, you know very little free space is left and that's where the game starts chugging (and crashing).

even tho the chunk I'm in is not loadedd yet

I had that very chunk loading issue too in All of Fabric 5, not sure what that's caused by.

it might be phosphor or farsight. but now it's much better

It's very unlikely it's Phosphor. I saw Farsight had some reported issues about memory usage and potential leaks, though nothing came of it.

If you still want high view distance, you can give Bobby a shot.

EGOIST1372 commented 2 years ago

I had that very chunk loading issue too in All of Fabric 5, not sure what that's caused by.

So it's not just me. thanks for the info and help you been provided for me. I really appreciated <3 yeah it seems that Bobby is a better option for me since I wanted farsight for servers that I play in. and Bobby is only affects servers and single player world that has edited name bobby-fallback

EGOIST1372 commented 2 years ago

IDK if this kinda "add support" need to be done from that side of development or this side

EGOIST1372 commented 2 years ago

@Fourmisain btw have you seen charmonium mod? it has really good performance and sounds pick up really fast(biome and elevation detection is really fast) can you check their code to see can we improve atmosfera with that? if you have time thanks <3

EGOIST1372 commented 1 year ago

@Haven-King @Fourmisain any news on the state of this mod and future plans? thanks in advance <3

Fourmisain commented 1 year ago

Haven't come around porting to 1.19.3 yet, not sure when I'll be able to. This might take a little more effort since this is where Mojang started putting major technical changes into minor patches, which has it's pros and cons - though I feel like 1.19.2 is still perfectly viable to use in the meantime. Apart from that, I / we are waiting on Haven-King.

Fourmisain commented 1 year ago

Here's a 1.19.3 / 1.20 port: #39, release found inside.

tajemniktv commented 2 months ago

Hey, any info or willingness for 1.21(.1) update? Pity that the main dev died and didn't add people willing to update it as maintainers, as it kinda made Atmosfera dead... And it was such a great mod. It still is. Sadly - without updates.

Anyways, 1.20 version works (?) on 1.21, except the mod menu config is borked, not sure how it plays out in game tho edit: nvm, it makess all resources/rps/tps to disable themselves

Fourmisain commented 2 months ago

The mod was surprisingly unaffected by the massive NBT changes in 1.20.5 and all that broke in 1.21 was literally just new Identifier() -> Identifier.of()

Here's the port: #40 Release found inside as always!

edit: I should note: I only did an extremely quick crash test, so let me know if something's afoot.

tajemniktv commented 2 months ago

Bro, did you just update a mod in less than an hour of some random dude asking online? 😭

I'm so gonna test it rn lmao

tajemniktv commented 2 months ago

Okay, so now that this one awesome person updated Atmosfera up to 1.21, how does it look like when used with Charmonium and/or MAmbience. I used it as a replacement, and sometimes along with Atmosfera, but not quite sure how well they go together. I do know there is stated conflict in mod json, but it'ws only conflicting, not breaking, so not sure if I should/can use it together...

(Also still confused as to how you just did that update so quickly lmaooo, like that's crazyXD)

EGOIST1372 commented 2 months ago

Fourmisain is a great dev that I asked to help to keep this mod alive and he is just awesome at it Many thanks to him <3 <3 <3

On Thu, Aug 15, 2024, 3:43 PM Gregory @.***> wrote:

Okay, so now that this one awesome person updated Atmosfera up to 1.21, how does it look like when used with Charmonium and/or MAmbience. I used it as a replacement, and sometimes along with Atmosfera, but not quite sure how well they go together. I do know there is stated conflict in mod json, but it'ws only conflicting, not breaking, so not sure if I should/can use it together...

(Also still confused as to how you just did that update so quickly lmaooo, like that's crazyXD)

— Reply to this email directly, view it on GitHub https://github.com/Haven-King/Atmosfera/issues/36#issuecomment-2291159130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUULT62C7UO6U2UO7M6R623ZRSLOFAVCNFSM5ZC6COD2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRZGEYTKOJRGMYA . You are receiving this because you commented.Message ID: @.***>

Fourmisain commented 2 months ago

Haven-King just added me as a maintainer and gave me push access on this repo!

I'll start merging the PRs and publishing the releases to CurseForge.

@Haven-King A bit of revenue share would be nice to have too if you haven't! Also, should I create a page on Modrinth too? People will wanna have it on there too.

Haven-King commented 2 months ago

@Fourmisain I've already assigned 100% of future revenue to you on CurseForge 🙂 You are welcome to create a Modinth page as well if you wish.

Fourmisain commented 2 months ago

Thanks a ton! Will create a Modrinth page soon too!

Fourmisain commented 2 months ago

Modrinth page is up and is already approved!