Almost self explanatory, except that some changes were necessary:
Most importantly, when they're baked, MyronUnbakedModels would try to always invoke Myron.load() to create and build the obj mesh. The problem with this is with Item/BlockItem models that use a ModelIdentifier: Myron.load() seems to only support absolute Identifiers, like myron:models/misc/torus.obj, but a ModelIdentifier gets passed to Myron.load(). I am not sure if this is a 1.17 change, but this prevents inventory models from working.
I made MyronUnbakedModel store the Obj and material map that was loaded in AbstractObjLoader, which is then directly used to build the Mesh. This fixes inventory obj models not rendering properly.
Almost self explanatory, except that some changes were necessary:
Most importantly, when they're baked,
MyronUnbakedModel
s would try to always invokeMyron.load()
to create and build the obj mesh. The problem with this is withItem
/BlockItem
models that use aModelIdentifier
:Myron.load()
seems to only support absoluteIdentifier
s, likemyron:models/misc/torus.obj
, but aModelIdentifier
gets passed toMyron.load()
. I am not sure if this is a 1.17 change, but this prevents inventory models from working.I made
MyronUnbakedModel
store theObj
and material map that was loaded inAbstractObjLoader
, which is then directly used to build theMesh
. This fixes inventory obj models not rendering properly.