HavocFramework / Havoc

The Havoc Framework.
https://havocframework.com
GNU General Public License v3.0
6.72k stars 949 forks source link

[Teamserver-Client--Bug]: Invalid C++ syntax causing GCC build failure #347

Closed gmorpheme closed 1 year ago

gmorpheme commented 1 year ago

Contact Details

@gmorpheme

What happened?

The following lines in DemoCmdDispatch have an unnecessary and illegal "CommandExecute::" qualifier on their member function declarations which apparently VisualStudio ignores but which causes build failures on GCC. Removing the qualifier fixes the build.

(https://github.com/HavocFramework/Havoc/blob/edaa969695d4bd08b0801c3215596be534cf1b45/client/Include/Havoc/DemonCmdDispatch.h#L75-L77)

These errors are actually visible but buried in quite a lot of other problems in #322 so you could regard this as a duplicate, but not sure anyone's noticed them there.

Did You Do a Pull First?

Latest (You performed a pull first)

Did You Try With the Dev Branch?

Yes (You tried using the dev branch but the problem persist)

Relevant log output

No response

Did You Read Over Your Issue First?

ScRiPt1337 commented 1 year ago

i am also having the same issue when i am trying to compile the client

I am able to compile the dev branch

gmorpheme commented 1 year ago

Apologies - misunderstood dev branch. Have verified it's fixed on dev.

winterrdog commented 1 year ago

Then it'd be a good time to close the issue 🙂