search

HavocFramework / Havoc

The Havoc Framework.
https://havocframework.com
GNU General Public License v3.0
6.72k stars 949 forks source link

Add automatic proxy detection #348

Closed nurfed1 closed 1 year ago

nurfed1 commented 1 year ago

This pull request will add automatic proxy detection when no static proxy is defined in the beacon configuration. I hope this would make sense?

Let me know if this could be merged or if I should change something?

S4ntiagoP commented 1 year ago

I really like this capability, but I can' really test this as I don't have a proper lab. But still I would rather have a (potentially) buggy implementation than none at all. I'm not sure if this approach will work on all "real life" scenarios on corporate internal networks, but the code makes sense to me.

If you don't have anything against this @Cracked5pider, we can merge.

Cracked5pider commented 1 year ago

looks good to me. seems good enough to be merged.

Cracked5pider commented 1 year ago

but instead of using GlobalAlloc and GlobalFree use NtHeapAlloc and NtHeapFree. then it should be ready to merge :)

S4ntiagoP commented 1 year ago

The use of GlobalFree is recommended on the Remarks section, so we should probably leave it as it is

Cracked5pider commented 1 year ago

oh i see. gotcha. yeah should be fine to merge then.