search

HavocFramework / Havoc

The Havoc Framework.
https://havocframework.com
GNU General Public License v3.0
6.72k stars 949 forks source link

fix bug & opt optimization client text encoding #359

Closed BlackTrace closed 1 year ago

BlackTrace commented 1 year ago

1.fix map race bug fatal error: concurrent map iteration and map write
goroutine 19 [running]: runtime.throw({0xd5b1be?, 0xc00027e150?}) /usr/lib/go-1.18/src/runtime/panic.go:992 +0x71 fp=0xc000287be0 sp=0xc000287bb0 pc=0x43caf1 runtime.mapiternext(0xd55092?) /usr/lib/go-1.18/src/runtime/map.go:871 +0x4eb fp=0xc000287c50 sp=0xc000287be0 pc=0x41866b Havoc/cmd/server.(*Teamserver).EventBroadcast(0xc000328640, {0x0, 0x0}, {{0x10, {0x0, 0x0}, {0xc000316060, 0x13}, {0x0, 0x0}}, ...}) /mnt/c/Havoc/teamserver/cmd/server/teamserver.go:682 +0xaa fp=0xc000287d60 sp=0xc000287c50 pc=0xb1288a Havoc/cmd.glob..func2.1({0xc000042310?, 0xc0000422a0?}) /mnt/c/Havoc/teamserver/cmd/server.go:50 +0x170 fp=0xc000287e68 sp=0xc000287d60 pc=0xb16570 Havoc/pkg/logr.Logr.ServerStdOutInit.func1()

2.opt client text encoding

S4ntiagoP commented 1 year ago

tried it out and it works, the code looks sensible so looks good to me