search

Havunen / SystemTextJsonPatch

SystemTextJsonPatch is a JSON Patch (JsonPatchDocument) RFC 6902 implementation for .NET using System.Text.Json
MIT License
102 stars 12 forks source link

Remove SystemTextJsonPatch.AspNet #1

Closed davidfowl closed 2 years ago

davidfowl commented 2 years ago

Doesn't seem like we should have this entire assembly just to make adding a JSON converter to MVC easier. There's also minimal APIs which has a different way to configure the JSON options.

Havunen commented 2 years ago

Yeah, I was just trying to avoid adding reference to 

  <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

in the main project, but now after testing that System.Text.Json.Nodes does not even exists in netcore3.1 or net5.0 it should be reasonable to combine these.

Maybe conditional compilation could be used anyway to include or exclude it. I will merge these projects

davidfowl commented 2 years ago

I don't think you need the reference at all, the extension method doesn't do enough to warrant another package IMO.

Havunen commented 2 years ago

Sure, I'm not aware of the consequences of that attribute tbh. Probably just better to document the behavior and drop the reference :)

Havunen commented 2 years ago

fixed in 0.0.2