Issue 2

[Khyzad]

Changed all instance variables so that they conform to HiDA's style guide.

---

This change is

[dagnir]

Reviewed 28 of 28 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

Minter/src/main/java/com/hida/model/AutoIdGenerator.java, line 35 [r1] (raw file):

        this.tokenType_ = tokenType;
        this.rootLength_ = rootLength;
        this.raxPermutation_ = getMaxPermutation();

Looks like this should be maxPermutation_

---

Minter/src/main/java/com/hida/model/BadParameterException.java, line 12 [r1] (raw file):

    private Object parameter_;
    private String rarameterType_;

Should be parameterType_

---

Minter/src/main/java/com/hida/model/IdGenerator.java, line 17 [r1] (raw file):

public abstract class IdGenerator {

    protected long raxPermutation_;

Should be maxPermutation_

---

Comments from Reviewable

[dagnir]

Fixes #2

[dagnir]

Review status: 24 of 28 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

Minter/src/main/java/com/hida/model/DefaultSetting.java, line 43 [r2] (raw file):

     * @param RootLength Designates the length of the id's root
     * @param SansVowels Dictates whether or not vowels are allowed
     * @param Auto Determines which generator, either auto_ or Custom, will be

minor: looks like should be "either Auto or Custom"

---

Comments from Reviewable

[dagnir]

Reviewed 4 of 4 files at r2. Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[dagnir]

Hey @Khyzad please fix the merge conflicts when you get the chance

[dagnir]

Reviewed 28 of 28 files at r3. Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[dagnir]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

_Minter/src/main/java/com/hida/model/DefaultSetting.java, line 43 [r2] (raw file):_

Previously, dagnir (Dongie Agnir) wrote…

> minor: looks like should be "either Auto or Custom" >

Just waiting on this fix and then this PR can be merged

---

Comments from Reviewable

[dagnir]

Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

Comments from Reviewable