Hax4us / java

This package of java (openjdk) is specially for termux users (without rooted phone) But it is unstable or beta version and I will update it soon with stable one
137 stars 123 forks source link

Invalid URL error while installation #2

Closed Harshiv-Patel closed 6 years ago

Harshiv-Patel commented 6 years ago

The installation script does not complete successfully, it says in output:

`\033[32m[*] Now wait until jdk-8 is installing ...🕛🕧\033[0m

wget: not an http or ftp url: https://github.com/Hax4us/java/releases/download/v8-151/jdk8_arm.tar.gz

\033[32m[] Moving jdk into system ...\033[0m mv: cannot stat 'jdk8_arm.tar.gz': No such file or directory
\033[32m[
] Extracting ...\033[0m tar: can't open 'jdk8_arm.tar.gz': No such file or directory

\033[32m[] Moving wrapper scripts for java 8\033[0m mv: cannot stat 'bin/': No such file or directory

\033[34mHappy java :D\033[0m`

Should there be echo -e for escape sequences or something?

Harshiv-Patel commented 6 years ago

Also it says "killed" after I manually installed your binaries. Glib method does not seem to work with armv7 devices, running Android Lollipop 5.1.1

Hax4us commented 6 years ago

@Harshiv-Patel thnx for info.. i will look into this ..actually i hve no any armv7 device now i will test

Hax4us commented 6 years ago

-e i forget lol

Harshiv-Patel commented 6 years ago

Please be careful in these scripts, you might accidentally screw up other things...

Harshiv-Patel commented 6 years ago

waiting for armv7 binaries eagerly here..

ghost commented 6 years ago

@Harshiv-Patel busybox's wget doesn't have ssl support, run

pkg in wget
hash -r

and volia!

Harshiv-Patel commented 6 years ago

Unfortunately the output of "java" after installation is single word "killed" without any error code or anything. Installing "wget" actually solved the original issue. The java binaries however, would not run, Should I close this issue and reopen other for binaries being "killed" ?

ghost commented 6 years ago

If it says killed, thats android that killed it. Java is quite a resource hungry program, your device may not have enough ram+swap, so the OOM killer came after it.

Speaking of which, what are your specs?

Also yeah, open a new issue.

Harshiv-Patel commented 6 years ago

Qcom snapdragon 410 processor, 2GB device RAM, running Android Lollipop 5.1.1. Termux has been pushed to memory card by "Apps2SD" app as it takes large amount of space(This hasn't affected working of Termux AFAIK). I think the "killed" message has something to do with my kernel being in "enforcing" mode. I've made a pull request for missing "-e" switch in "configurejava.sh" script. So I'll close this issue when it is merged.

ghost commented 6 years ago

My device runs java fine with selinux in enforing mode, so that can't be the case.

Harshiv-Patel commented 6 years ago

what device are you using for testing @aiisuika ? Also closing this issue as pull request is merged.

ghost commented 6 years ago

Exynos 7885 Octa (2x2.2 GHz Cortex-A73 & 6x1.6 GHz Cortex-A53) 4GB RAM, Android Nougat 7.1.1 Termux is in internal storage.

Harshiv-Patel commented 6 years ago

so it's on, arm v8. I'll have to check it on any other armv8 devices. perhaps it doesn't work on arm v7 devices.

ghost commented 6 years ago

The pr is broken, ee isn't expanded on lines with ee" .... lol

Harshiv-Patel commented 6 years ago

strange. shopt -s expand_aliases is supposed to enable alias expansion. The "echo" without the "-e" switch is not supposed to process escape sequences, or is it inverse of it in arm v8 binaries?

ghost commented 6 years ago

ee" ... parses as ee<space>... ee " ... parses as echo -e <space>...

Harshiv-Patel commented 6 years ago

Thank you for pointing it out. A new PR I suppose.