search

HaxeCheckstyle / haxe-checkstyle

Haxe Checkstyle
http://haxecheckstyle.github.io/docs
MIT License
124 stars 27 forks source link

No Fail with Github Workflow #509

Closed inc0der closed 3 years ago

inc0der commented 3 years ago

I noticed when using checkstyle with a GitHub workflow that the step won't fail when checkstyle detects issues. I'm fairly new to GitHub workflows so I could be missing something obvious but I figured I would at least create an issue to start the discussion.

Examples: You can check out the 1st failed workflow here under npm run ci-checkstyle

I have another failed run here same section, but this time its an actual error due to a bad character within the checkstyle.json`

Both examples fail within the CI but the actual steps succeed and the GitHub workflow passes.

AlexHaxe commented 3 years ago

add --exitcode to your checkstyle command to make it fail with a non zero exitcode indicating the number of errors found (warning and info level issues don't increase exitcode)