search

HaxeCheckstyle / haxeparser

A Haxe parser for Haxe
61 stars 23 forks source link

support for KwdExtern in package and import lines #28

Closed AlexHaxe closed 8 years ago

AlexHaxe commented 8 years ago

https://github.com/HaxeFoundation/haxe/blob/haxe-3.2.1/parser.ml#L526 https://github.com/HaxeFoundation/haxe/blob/haxe-3.2.1/parser.ml#L665-666

Simn commented 8 years ago

Thanks!

Simn commented 8 years ago

@AlexHaxe: As a heads up, this PR was incomplete. I addressed the missing cases in this commit: https://github.com/Simn/haxeparser/commit/a82a2784a89874d2c4586ba211cb46caa509fc14

AlexHaxe commented 8 years ago

Thanks, I didn't check all extern references in the ocaml source.

When comparing your changes with the development branch I find that in exprNext the Dot case does not handle Kwd(KwdNew) and Binp(OpOr) like in ocaml.

Simn commented 8 years ago

OpOr doesn't matter because it's just for display debugging.

.new should be supported though!