HaxeExtension / extension-admob

OpenFL extension for "Google AdMob" on iOS and Android.
Other
58 stars 25 forks source link

add rewarded video mediation #23

Closed man2 closed 7 years ago

man2 commented 8 years ago

adcolony integration still a little bit hackish

fbricker commented 7 years ago

Hi, I'm checking on this now... Looks really nice 👍

Have you by chance have something for the iOS? I'm considering merging this PR and adding gradle support for android so it works on OpenFL 4.1+ as well.

Also, do you know if the connectors are something we can distribute inside the extension or if we should link them from the android-sdk repository?

man2 commented 7 years ago

mediation connectors? I think we can distribute it inside the extension, but it will need extra care if the connectors get updated, we should update the distribution as well

fbricker commented 7 years ago

I'm trying to merge this request, but I've noticed that AdColonyAdapter is kind of mandatory for this implementation (as com.jirbo.adcolony.AdColonyAdapter is directly used on AdMobEx.java and adcolony-mediation is forced on project.properties).

I wonder if there's a way of making this optional...

Anyway, I've opened a new branch named "mediation" where I've merged this changes. I hope we can soon add what's missing so we can merge it on main and release it un haxelib :)

So far I guess this is the only missing steps: