search

HaxeExtension / extension-facebook-alt

OpenFL extension to use Facebook in your app
MIT License
17 stars 7 forks source link

Improved usage. #8

Closed daPhyre closed 8 years ago

daPhyre commented 8 years ago
Tomobodo commented 8 years ago

Thanks for the java sdk version fix!

I'm not sure About the PROJ-Info.plist template. I prefer to not use template because I used to have a lot of extension in my app, and when they used template for the same file, well i had errors. That's why i made the command to only add the part needed in the xml instaed of overriding it completly by a template.

I think the template should be in the user project and not in the extensdion to avoid overriding potential others extensdion template (like ads).

Instead of completly removing the part about the facebook command I would suggest to make a custom template including every modificaation needed by every used extension.

What do you think?

Edit : oh i double checked and that's acctually exactly what you did. Sorry.

daPhyre commented 8 years ago

I was just about to tell you that, right before noticing your edit. I'm glad to contribute.

PS: The library in haxelib seems to be quite out of date, it still doesn't have support for iOS even. Do you have any plans to update it soon?

Tomobodo commented 8 years ago

I know, but my haxelib password doesn't work any more and I can't find a way to reset it. I asked to haxelib a new one like six month ago but no answer. I'll ask again, maybe i'll be luckier this time.