HaxeExtension / extension-share

Share Extension for OpenFL
Other
43 stars 12 forks source link

Fixed #1

Closed andrew-git closed 10 years ago

andrew-git commented 10 years ago

First of all thank you for your extension.

A few moments:

  1. Share.hx: var cleanUrl:String=StringTools.replace(url,'http://',''); does you need to also clean 'https'?
  2. Share.hx: default: 'https://www.facebook.com/dialog/feed?app_id='+Share.facebookAppID+'&description='+text+'&display=popup&caption='+subject+'&link='+url+'&redirect_uri=http://www.puralax.com/shared/&images[]='+image; Hardcoded redirect_uri
  3. Is it possible to replace deprecated Feed Dialog (https://developers.facebook.com/docs/sharing/reference/feed-dialog/v2.1) with Share dialog, that doesn't require the user to be logged into your app using Facebook (https://developers.facebook.com/docs/android/share) with Feed Dialog as fallback (https://developers.facebook.com/docs/android/share#linkfeed)?
fbricker commented 10 years ago

Hi, I've made changes 1 and 2. I'll take a look at the point 3 soon.

Thanks!

andrew-git commented 10 years ago

Thanks a lot!

fbricker commented 10 years ago

Hi, I'm looking at point 3. Can you provide an example of how the share URL for facebook should be in order to use the new sharing API? I think the link in here: https://developers.facebook.com/docs/android/share is just of Android (and I need a link for web-sharing), as for Android the extension uses native share interface (and for iOS, I'll do the same soon).

PS: I think I hate Facebook documentation :( It's too long and you have to learn about a lot of useless stuff (they should provide more simplified and standard examples with clean and more stable APIs).

andrew-git commented 10 years ago

I'll try to find something, but fb documentation really boring and constantly changed

andrew-git commented 10 years ago

Earlier I use url for sharing, but not sure if it working now "http://www.facebook.com/sharer.php?s=100"

fbricker commented 10 years ago

Hi, I've updated the library so it calls Native share on both (Android and iOS). The web-sharing remains just for the rest of the platforms.

I originally used the method that requires the facebook APP ID, becauses the sharar.php was deprecated. But it looks they reversed that decision (http://www.joshuawinn.com/facebooks-sharer-php-longer-deprecated-2014/), so I'll test the sharing using this instead :)

Thanks for your feedback :+1:

andrew-git commented 10 years ago

Thank you for your work!

andrew-git commented 10 years ago

"But it looks they reversed that decision (http://www.joshuawinn.com/facebooks-sharer-php-longer-deprecated-2014/), so I'll test the sharing using this instead :)"

Looks like it can't share custom parameters (text or images) it take info from page (url)

fbricker commented 10 years ago

Mmm... I'll test it and see what happens. They change a lot of things constantly, so I guess the only way to know is testing.