HaxeFlixel / flixel-addons

Additional classes for HaxeFlixel
170 stars 139 forks source link

Fix the clipping issue in FlxBackdrop #372

Closed NeeEoo closed 2 years ago

NeeEoo commented 2 years ago

This fixes a bug where when the camera is zoomed out, the backdrop stops rendering at the edges. All that needs to be done is backdrop.camZoom = 0.5; since making this run based on the current camera zoom would take up a lot of memory on blit

Fixes https://github.com/HaxeFlixel/flixel/issues/2649

Geokureli commented 2 years ago

I still haven't seen a reliable repro for the issue you linked. Do you have simple way I can see it?

Also we shouldn't need a new property to fix 2649, blit targets are not a high priority, and {} brackets need to be on the following line

NeeEoo commented 2 years ago

@Geokureli take the linked issue repro you were trying reproduce, then add this FlxG.camera.zoom = 0.5;

Geokureli commented 2 years ago

@NeeEoo Thanks for explaining the cause of the issue, as for the issue, I went in a new direction and remade FlxBackdrop from the ground up in #373. It still needs some testing before merging, tho