HaxeFlixel / flixel-addons

Additional classes for HaxeFlixel
170 stars 139 forks source link

Correct some mistakes with parameters in doc comments #376

Closed DalekCraft2 closed 1 year ago

DalekCraft2 commented 1 year ago

Did this because the parameters would not show their descriptions when hovered over if they were not written correctly in the doc comments. Also removed redundant instances of "returns" from some "@return" tags. Also inadvertantly ran the auto-format on some files after editing and saving them.

Geokureli commented 1 year ago

I really don't want my formatting options in FlxBackdrop removed, the autoformatter is just less readible, no doc seems to have been changed there can it be reverted

Geokureli commented 1 year ago

changing the settings.json template so that it ignores lines you haven't edited, try to use these settings in the future https://github.com/HaxeFlixel/flixel-templates/commit/f03e4b0ef1465301a2e6b28929bed0bc7e67ec95

DalekCraft2 commented 1 year ago

Okay, I will revert the FlxBackdrop format and use those settings in the future.

DalekCraft2 commented 1 year ago

Are any more changes needed? I do not get changes requested on pull requests often, so I am unsure of whether "1 review requesting changes" means I still have to do something.

Geokureli commented 1 year ago

thanks!