search

HaxeFlixel / flixel-docs

Documentation for HaxeFlixel
72 stars 135 forks source link

Reference to inexistent code in HaxeFlixel Tutorial #155

Closed JefePapaya closed 7 years ago

JefePapaya commented 8 years ago

On section 11 of the Turn Based RPG Tutorial, Game Over Menu (http://haxeflixel.com/documentation/game-over-menu/), there is a reference to an inexistent code.

On line 7 of this file it says

  1. The first thing we want to do is stop our CombatHUD from stopping once the player has been defeated. So in doneResultsIn(), remove the if (outcome != DEFEAT) statement.

There's no such if (outcome != DEFEAT) statement in CombatHUD.hx. Maybe the text is outadated and this existed in a previous version.

Gama11 commented 8 years ago

Are you sure this wasn't added in a previous step somewhere? It's not surprising that CombatHUD.hx in flixel-demos doesn't have that line, that's the final version of the tutorial game, and it does say to remove that line in that step. :)

JefePapaya commented 8 years ago

Well, I may have misread something, but this same file is referenced from the previous step. This file isn't modified in the previous step, so it still seems wrong. I've noticed some other things off. I hope getting better with HaxeFlixel and then making pull requests.

JefePapaya commented 8 years ago

I think the problem is asking the reader to use the final CombatHUD file, instead of giving they a version to modify accordingly. I just found another inconsistency with this, moving forward to section 13, the tutorial instructs to add a code that was already in the file. I hope you have the time to take a look. It's easier to get the picture if you look from section 10 to 13.

KosnIre commented 8 years ago

There's no such if (outcome != DEFEAT) statement in CombatHUD.hx. Maybe the text is outadated and this existed in a previous version.

I just noticed this too when I was following along. It's not a big issue, but I agree that it should be changed. Whether that means removing the text, or creating a partially-complete CombatHUD file1, I'm not sure.

1This might help with #171 as well.