HaxeFoundation / HaxeManual

The official Haxe manual
https://haxe.org/manual/
Creative Commons Attribution 4.0 International
221 stars 153 forks source link

Update for 4.3 #526

Closed Aurel300 closed 1 year ago

Aurel300 commented 1 year ago

Closes #524 (except for the -w comment).

Left to do:

Simn commented 1 year ago

Awesome, thanks! Will review tomorrow when I'm back home and also add the warning docs.

kLabz commented 1 year ago

new section in Language Features: Custom defines documentation new section in Language Features: Custom metadata documentation

I think both are missing the 3rd way which is through a lib's haxelib.json, added there: https://github.com/HaxeFoundation/haxelib/pull/573

kLabz commented 1 year ago

is it just that $v etc are now disallowed outside of macro expressions?

All $... reification are now disallowed outside actual macro reification, yeah. Not much to say there, but should probably point out that the fix (that is compatible with earlier versions) is just to remove $v{ (or other ones) and } around the expression.

pretty error reporting modes

Not sure when I'd have time to handle that if you want me to (kid's holidays..) but I can do it if you want. Would need to make sure it's clear that current define names are only for 4.3.0 and will change in 4.3.1 and in nightlies

Aurel300 commented 1 year ago

I think both are missing the 3rd way which is through a lib's haxelib.json, added there: HaxeFoundation/haxelib#573

I know, I omitted these, because I think that's for haxelib docs?

kLabz commented 1 year ago

Oh haxelib does have docs indeed

Aurel300 commented 1 year ago

pretty error reporting modes

Not sure when I'd have time to handle that if you want me to (kid's holidays..) but I can do it if you want. Would need to make sure it's clear that current define names are only for 4.3.0 and will change in 4.3.1 and in nightlies

@kLabz Have a look at the current version. I did not document the file redirections, unsure those are important for the manual.

kLabz commented 1 year ago

Yeah it's probably best not to document it as it's mostly for tools. Doc on pretty errors and reification lgtm

Aurel300 commented 1 year ago

I'll merge this now so that the new content is available (and we don't get PRs that re-do the work, like #529). We can update the docs link once it is available…

T1mL3arn commented 1 year ago

I'll merge this now so that the new content is available

I can't see anything from this on Haxe website.