search

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.17k stars 656 forks source link

Missing field generation regression #11472

Open RblSb opened 9 months ago

RblSb commented 9 months ago

Commit https://github.com/HaxeFoundation/haxe/commit/52bb47510efdd5ecb945bc016b015bb1b21dd456 breaks missing field generation in vshaxe:

class Main {
    static function main() {
        foo = 0;
    }
}

Generation before: static var foo:Int; Now: static var foo:?; (monomorph)

RblSb commented 9 months ago

Little more context: MissingFieldDiagnostics now returns type : {kind : TMono} instead of abstract around Int. Can be viewed with trace(fields) around here https://github.com/vshaxe/haxe-language-server/blob/0f3418b7725d48e053c53b805b51f58ce372378f/src/haxeLanguageServer/features/haxe/codeAction/diagnostics/MissingFieldsActions.hx#L130

RblSb commented 5 months ago

I hope this regression will be fixed for the next release, at the moment this useful ide feature is broken in dev builds. Would like to migrate to dev since compilation server is at sad state for me in stable release with many fake display recursive inline errors.