search

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.14k stars 656 forks source link

[macro] Remove CompilationServer.setModuleCheckPolicy options #11615

Closed kLabz closed 6 months ago

kLabz commented 6 months ago

I'm really not sure it ever worked properly, and was often triggering X is redefined from X errors.

Since hxb (#11504) has been merged, CompilationServer.setModuleCheckPolicy seems utterly broken (as expected for things that would tend to break over time with compilation server: with hxb, it break fast) and triggers BadModule errors.. which are new errors that would have resulted in a X is redefined from X before.

I'm currently removing it entirely, but I can see some real use case in there for CheckFileContentModification (and possibly NoCheckFileTimeModification) policy which seems like a legit one. Will look into simplifying the previous API to only allow these two. I kept functionality for previous CheckFileContentModification and NoCheckFileTimeModification policies.

Closes #6993

Simn commented 6 months ago

I agree with the change generally but the renaming seems a bit pointless...