search

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.14k stars 656 forks source link

[cppia] Generate scriptable functions for overriden functions #11773

Closed Aidan63 closed 2 weeks ago

Aidan63 commented 2 weeks ago

Fixes https://github.com/HaxeFoundation/hxcpp/issues/1150

Test has been added in this hxcpp merge https://github.com/HaxeFoundation/hxcpp/pull/1154

That hxcpp merge is failing due to the new test, once this is merged the CI on that hxcpp merge should be re-ran and it will then pass.

Simn commented 2 weeks ago

Does this interact with overloads somehow given that we're comparing methods by name?

Aidan63 commented 2 weeks ago

I don't think so. Overloads only really work on extern classes iirc, and that code is only ran on haxe classes and interfaces.