HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.19k stars 656 forks source link

Fix licensing #11782

Closed Maniues closed 1 month ago

Maniues commented 1 month ago

Split licenses to directory-based licensing to precise what files are under GPL or MIT.

Maniues commented 1 month ago

@ncannasse @Simn

Simn commented 1 month ago

I don't know if we want to assert that all other files are part of the Haxe compiler. I don't think you typically declare a tests directory as part of a compiler, and the libs directory is another situation entirely.

But I'm fine with clarifying that the Haxe standard library refers to std in particular.

Maniues commented 1 month ago

I don't know if we want to assert that all other files are part of the Haxe compiler. I don't think you typically declare a tests directory as part of a compiler, and the libs directory is another situation entirely.

But I'm fine with clarifying that the Haxe standard library refers to std in particular.

It's hard for me to tell later if the files included in the tests are GPL or not. Same for all files in the top directory

Maniues commented 1 month ago

And there can be exception for particular directories like libs

Maniues commented 1 month ago

@Simn like these files:

Maniues commented 1 month ago

@Simn what do you think about that?

Simn commented 1 month ago

To be honest I don't understand what you're saying. You mention that there can be exceptions, but the change in this PR doesn't seem to make exceptions and says "all other files".

Maniues commented 1 month ago

I haven't done this yet, I will add it in a few minutes.

I just want to make sure it is okay.

Maniues commented 1 month ago

@Simn What about now?

Simn commented 1 month ago

I like that "If a file does not have a license header" clause, that seems uncomplicated enough.

So I think this is good now, but let me leave this PR open for a few days in case someone who knows about all this stuff happens to pass by!

Maniues commented 1 month ago

Okay, thanks

Maniues commented 1 month ago

So I think this is good now, but let me leave this PR open for a few days in case someone who knows about all this stuff happens to pass by!

@Simn any updates here? I really liked Haxe, but these licensing issues here, in format repo and in api.haxe.org, so I don't know if I can use it under Open Source licenses.