HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.15k stars 656 forks source link

Docgen vs. tracy #11789

Closed Simn closed 2 hours ago

Simn commented 3 hours ago
+ make -s xmldoc
Local repository created (/home/runner/work/haxe/haxe/extra/.haxelib/)
Installing hxcpp from https://github.com/HaxeFoundation/hxcpp
  Current version is now git
Done
Installing hxjava from https://github.com/HaxeFoundation/hxjava
  Current version is now git
Done
 WARNING  /home/runner/work/haxe/haxe/std/neko/vm/Ui.hx:67: characters 15-19

 67 |   var l = new Lock();
    |               ^^^^
    | (WDeprecated) This typedef is deprecated in favor of sys.thread.Lock

 WARNING  /home/runner/work/haxe/haxe/std/cpp/net/ThreadServer.hx:31: characters 8-14

 31 |  var t:Thread;
    |        ^^^^^^
    | (WDeprecated) This typedef is deprecated in favor of sys.thread.Thread

 ERROR  /home/runner/work/haxe/haxe/std/cpp/vm/tracy/TracyProfiler.hx:26: characters 8-58

 26 | #error "This class cannot be used without -D HXCPP_TRACY"
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | This class cannot be used without -D HXCPP_TRACY

make: *** [Makefile:[17](https://github.com/HaxeFoundation/haxe/actions/runs/11341552080/job/31540055616?pr=11768#step:11:18)5: xmldoc] Error 1
Error: Process completed with exit code 2.

cc @dazKind

dazKind commented 3 hours ago

@Simn Oh, didnt think of docgen when adding the guard. I disabled it for the moment

Simn commented 3 hours ago

Yes I think that's best.

It's a bit silly that docgen doesn't run on PRs because we sometimes come across problems like this after merging.

Simn commented 2 hours ago

Fixed by https://github.com/HaxeFoundation/haxe/pull/11790