[PHP] reflect api breaks sys.db.Manager.doUpdate when php version > 5.2

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit

https://haxe.org

6.14k stars 656 forks source link

[PHP] reflect api breaks sys.db.Manager.doUpdate when php version > 5.2 #1990

Closed postite closed 7 years ago

postite commented 11 years ago

in sys.db.Manager.doUpdate function this line https://github.com/HaxeFoundation/haxe/blob/development/std/sys/db/Manager.hx#L223 generates $cache->{$name} = $v; in PHP

which seems to no longer works in new php versions (ex 5.4 ) but it's fine with php 5.2

J-d-H commented 11 years ago

I think this could be related to #1926 but I suggested this change 2 month ago and I'm not as into it anymore as I was that time.

RealyUniqueName commented 7 years ago

Since it's a three years old issue without any activity for years, unit tests are ok and SPOD moved to separate library, i guess this issue is not relevant anymore. Feel free to reopen.