[python/php/java] Move SslSocket impl back to sys.ssl package

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit

https://haxe.org

6.19k stars 656 forks source link

[python/php/java] Move SslSocket impl back to sys.ssl package #7542

Open kevinresol opened 6 years ago

kevinresol commented 6 years ago

They currently sits in:

python.net.SslSocket
php.net.SslSocket
java.net.SslSocket

Simn commented 5 years ago

I don't think this is 4.0 priority, but I'm also not quite sure what this is about.

kevinresol commented 5 years ago

If I understand correctly, these implementations are actually compatible with sys.ssl.Socket, moving them back to that package saves user from the conditional compilation mess.

Maybe just a typedef is fine.

Simn commented 5 years ago

I agree, but that doesn't sound like it's high priority. Moving to 4.1 for now.

barisyild commented 4 years ago

the same problem exists in the csharp target.

kevinresol commented 4 years ago

The problem is: C# doesn't have a SslSocket implementation: https://github.com/HaxeFoundation/haxe/issues/7543