search

HaxeFoundation / haxe

Haxe - The Cross-Platform Toolkit
https://haxe.org
6.16k stars 658 forks source link

[js] js.html.push.PushSubscriptionOptionsInit is missing userVisibleOnly field #9027

Open nadako opened 4 years ago

nadako commented 4 years ago

userVisibleOnly: A boolean indicating that the returned push subscription will only be used for messages whose effect is made visible to the user.

It's a bit annoying because this field is actually required currently in e.g. Chrome.

nadako commented 4 years ago

It's commented out in the IDL for some reason: https://github.com/HaxeFoundation/html-externs/blob/52a15145a2b036c389b422a7d694a90aaa7a66dd/webidl/mozilla/PushManager.webidl#L11

haxiomic commented 4 years ago

Seems to be commented out in the latest IDLs too https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/PushManager.webidl#L11

When I do the next html-externs update I will patch it in manually