[analyzer] immediately-invoked-by-analyzer anonymous functions are not optimized away

[nadako]

class Main {
    static function main() {
        var f = a -> a;
        trace(f(3));

        trace((a -> a)(3));
    }
}

console.log("src/Main.hx:4:",(function(a) {
    return a;
})(3));
console.log("src/Main.hx:6:",3);

This is because IIFE optimization is done before the analyzer optimization, but maybe it should be done both before and after it.

[Simn]

This is difficult because inlining can put bad things in value places. I doubt the current analyzer architecture could support this.

[nadako]

Not sure what you mean by bad things here :)

[Simn]

All of the stuff that used to cause $this on JS and at this point probably causes crashes and fireworks on various other targets.

[nadako]

I guess I need an example. I quickly tried adding Optimizer.reduce_expression tctx call after the analyzer run and it seems to fix the code in the original post, but I guess you're talking about something more complicated?

[Simn]

Check the JS unit test output and look for $this.

[nadako]

Oh, I see, it indeed added a couple of them (while optimizing a lot of other stuff though).