search

HaxeFoundation / haxelib

The Haxe library manager
https://lib.haxe.org/
MIT License
172 stars 78 forks source link

Second user in contributors can't submit. #211

Closed ibilon closed 9 years ago

ibilon commented 9 years ago

Hi,

I'm trying to submit HaxePunk 2.5.4 but it isn't working for me,

in haxelib.json we have "contributors": ["heardtheword", "_ibilon"], and it was pushed to haxelib for the previous version (2.5.3, last in semver order).

But I get User '_ibilon' is not a developer of project 'HaxePunk'.

Is there anything else that should have been done or is it a bug?

back2dos commented 9 years ago

That is weird. Just tried it myself and it works.

But apparently in your the database was not updated correctly, because according to the server you are not a contributor of HaxePunk: http://lib.haxe.org/u/_ibilon

Would you be so kind as to have the update be submitted by heardtheword to see if that updates you project list correctly?

MattTuttle commented 9 years ago

Submitted. I'm pretty sure we've done this in the past. Can you double check that _ibilon is listed as a contributor now?

back2dos commented 9 years ago

Nope. I've checked the code and this is quite a silly bug. Haxelib only considers the project changed if the number of developers changes: https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Repo.hx#L191

Since you are replacing "ibilon" with "_ibilon" the code assumes there are no changes. For now, can you please just resubmit (the same version) with ["heardtheword", "ibilon", "_ibilon"] (and then follow up with ["heardtheword", "_ibilon"] if you want to)?

MattTuttle commented 9 years ago

Done. Thanks for looking into this.