search

HaxeFoundation / haxelib

The Haxe library manager
https://lib.haxe.org/
MIT License
172 stars 78 forks source link

'haxelib submit' does not work as documented #498

Closed notboring closed 4 years ago

notboring commented 4 years ago

When submitting a local directory to haxelib using 'haxelib submit' I was asked to enter a package name. When entering the name of the package I received a file error. I was a bit confused at first but after trying a few things I noticed that you need to pass a path along with the submit command if you want to commit the local directory: 'haxelib submit .' The documentation states 'Alternatively you can run haxelib submit without argument to have Haxelib zip and submit the current directory (excluding names starting with a dot).' so I wonder if this is an issue with the docs or with the current haxelib version. (or maybe with my local installation?)

This is on windows 10 using Haxe 4.0.5.

RealyUniqueName commented 4 years ago

I can't find the code in haxelib client which would do that. It's probably a misleading documentation.

RealyUniqueName commented 4 years ago

But if the argument is a path to an existing directory, then haxelib client should indeed zip and submit it: https://github.com/HaxeFoundation/haxelib/blob/e7cb62181303eb61737fe06b5784cab41a58a53f/src/haxelib/client/Main.hx#L625-L629

notboring commented 4 years ago

Thanks for looking into this. I submitted a pull request for the haxelib documentation repo.