HaxeFoundation / hx3compat

Haxe 3 compatibility lib for Haxe 4
MIT License
16 stars 16 forks source link

fix compilation error in TestRunner when using jvm target #21

Closed sebthom closed 1 year ago

sebthom commented 1 year ago

This fixes hx3compat/1,0,3/std/haxe/unit/TestRunner.hx:96: characters 12-20 : [Ident:java.lang.String -> Unknown<0>] __java__ when using the jvm target.

sebthom commented 1 year ago

@Simn is that the best way to fix it?

Simn commented 1 year ago

I don't really understand where that __java__ comes from. java.lang.System.out.print(str) works on the JVM target as well, and I cannot reproduce the problem in isolation. Are you somehow using the JVM target with an older standard library or something like that?

sebthom commented 1 year ago

I am puzzled too. I cannot reproduce it locally but when I do fresh builds on github actions I always get this error.

sebthom commented 1 year ago

Actually I also get this when running github action jobs locally via nektos/act and there are definitely no caches involved.

sebthom commented 1 year ago

This is an example job where I get the error https://github.com/vegardit/haxe-doctest/actions/runs/4001134229

Simn commented 1 year ago

Oh, look: https://github.com/HaxeFoundation/hx3compat/commit/db6303e05e6b6827d38f8c6236c87a6041263465

You came across this before, the issue seems to be that the change simply hasn't been released.

sebthom commented 1 year ago

wow, I totally forgot about it. are you able to release it?

Simn commented 1 year ago

Done! And sorry this took so long, I somehow never received notifications for this repository.

sebthom commented 1 year ago

awesome, thanks!