imcasper
commented
5 years ago It seems I'm confused in the branches. I want to make a view restriction just for an array. Because it leads to crash of the debugger (Inteliji Idea, protocol v 1.1). In any case, it seems strange to me that a debugger crash 300 entries in the array. In general, the debugger often crash, but I did not have time to find other reasons. Crash -- I mean critical uncaught exception (in debugger) and program stop.
So, what is your reason for doing this? What are you trying to accomplish? Where do you expect these changes to be used?
I'm asking because you've updated the protocol_v1.1 branch -- to a newer protocol version. We can't do that; it's effectively a frozen branch, and updating it MUST NOT change the protocol in any way. Only bug fixes are allowed there.
IntelliJ IDEA requires the 1.1 version - using the protocol_v1.1 branch. Visual Studio requires the 1.2 version - using the master branch. (Not sure about VsCode.) (What version does HaxeDevelop use, I wonder?)
It looks to me that this will change the format of the data coming through the protocol, which means that we need to bump this to a 1.3 version, which also requires changing the rendezvous strings as well as the reported version number.
(I can always create a protocol_v1.2 branch from the master before your changes to support Visual Studio.)