Fix mysql_select_db and mysql_close

AlexHaxe commented 1 year ago

after installing a new Linux server I noticed some of my tools failed to connect to a mariadb database. some debugging and packet sniffing and comparing with PHP communication later I came to the conclusion it's the extra 0x00 byte at the end of database names in mysql_select_db that makes it fail.

my changes fix failing mysql tests on my system (while failing on master branch), but I haven't tested Windows or Mac. currently they silently fail on azure, so hopefully PR will fix CI as well.

I've also added a COM_QUIT packet for mysql_close because mariadb always complained about aborted connections since Haxe would just close socket its connection without notifying server side.

Simn commented 1 year ago

Thanks!

Japan50079 commented 1 year ago

correct

Simon Krajewski @.***>于2022年11月19日周六18:52写道：

Merged #1015 https://github.com/HaxeFoundation/hxcpp/pull/1015 into master.

— Reply to this email directly, view it on GitHub https://github.com/HaxeFoundation/hxcpp/pull/1015#event-7849420748, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4I3M6E4A7CC2FYQI7UBVB3WJCWO3ANCNFSM6AAAAAAR6RDVWQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Japan50079 commented 1 year ago

Just change it

Simon Krajewski @.***>于2022年11月19日周六18:52写道：

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/HaxeFoundation/hxcpp/pull/1015#issuecomment-1320858591, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4I3M6HNLH7XF7VFZIEKUOTWJCWPFANCNFSM6AAAAAAR6RDVWQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

HaxeFoundation / hxcpp

Fix mysql_select_db and mysql_close #1015