HaxeFoundation / hxcpp

Runtime files for c++ backend for haxe
Other
298 stars 189 forks source link

Make sys_read_dir errors consistent between platforms #1095

Closed tobil4sk closed 4 months ago

tobil4sk commented 8 months ago

Haxe documentation specifies that an exception should be thrown if the path is not a valid directory:

If path does not denote a valid directory, an exception is thrown.

This was already the case on all platforms except Windows, where null was returned. Now the behavior is consistent.

tobil4sk commented 4 months ago

@Simn This one also seems to be affected by the flaky test.

tobil4sk commented 4 months ago

Looks green now!